Conversation
Contributor
|
@v-federicoar Thanks for looking into that! |
Contributor
|
I got them all deployed now, too |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the claim-check pattern samples to a newer .NET target and Azure libraries, refreshes Bicep templates with newer API versions, and clarifies the documentation and run instructions for each sample.
Changes:
- Bump all claim-check samples (1–4) from .NET 9 to .NET 10 in documentation and project files, and update Microsoft.Extensions/Functions Worker/Application Insights package versions accordingly.
- Refresh Bicep templates for samples 1–4 to use newer resource API versions and clean up role definition resource naming.
- Improve sample READMEs (typo fixes, clearer wording,
func start --dotnet-isolated, extra guidance on using thepayloadscontainer) and tighten configuration validation for Sample 2’s consumer.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| claim-check/code-samples/sample-4/readme.md | Documents Sample 4 updates: .NET 10, refined feature description, corrected diagram alt text, updated prerequisites, and explicit func start --dotnet-isolated usage. |
| claim-check/code-samples/sample-4/bicep/main.bicep | Updates role definition and resource API versions, Event Hubs namespace API, and keeps Kafka-enabled Event Hubs infra aligned with newer RP versions. |
| claim-check/code-samples/sample-4/FunctionConsumer4/FunctionConsumer4.csproj | Targets net10.0 and updates Functions Worker and Application Insights Worker/ApplicationInsights packages to newer versions for the Sample 4 consumer Function. |
| claim-check/code-samples/sample-4/ClientProducer4/ClientProducer4.csproj | Targets net10.0 and bumps Microsoft.Extensions.Configuration/Logging package versions for the Sample 4 Kafka-based producer. |
| claim-check/code-samples/sample-3/readme.md | Updates to .NET 10, fixes several typos, clarifies func start --dotnet-isolated, and adds guidance on using the payloads container; one remaining line incorrectly refers to Event Hubs instead of Service Bus. |
| claim-check/code-samples/sample-3/bicep/main.bicep | Bumps API versions for role definitions, storage, Event Grid, Service Bus, and diagnostics; retains Service Bus–centric infra for Sample 3 but still has a misspelled Service Bus role resource name. |
| claim-check/code-samples/sample-3/FunctionConsumer3/FunctionConsumer3.csproj | Targets net10.0 and updates Functions Worker and Application Insights Worker/ApplicationInsights packages for the Sample 3 Service Bus consumer. |
| claim-check/code-samples/sample-2/readme.md | Moves Sample 2 docs to .NET 10, fixes download typos, clarifies deployment steps, and adds guidance to upload payloads into the payloads container. |
| claim-check/code-samples/sample-2/bicep/main.bicep | Updates role definition, storage, Event Grid, Event Hubs, diagnostics, and role assignment API versions, and renames Event Hubs role symbols from ...Ownwer... to ...Owner.... |
| claim-check/code-samples/sample-2/ClientConsumer2/SampleSettingsValidator.cs | Refines configuration validation to report only missing settings and improves the error message, but leaves the XML <param> tag out of sync with the renamed requiredSettings parameter. |
| claim-check/code-samples/sample-2/ClientConsumer2/ClientConsumer2.csproj | Targets net10.0 and updates Microsoft.Extensions.Configuration/Logging package versions for the Sample 2 Event Hubs consumer. |
| claim-check/code-samples/sample-1/readme.md | Updates Sample 1 docs to .NET 10, fixes Event Grid/queue wording, updates func start to --dotnet-isolated, and clarifies that payloads go into the payloads container, but still configures STORAGE_ACCOUNT_NAME without lowercasing the prefix. |
| claim-check/code-samples/sample-1/bicep/main.bicep | Updates role definition and storage/Event Grid API versions and changes the storage account name to use toLower(namePrefix) for validity, which now diverges from the README’s config instructions if users choose uppercase prefixes. |
| claim-check/code-samples/sample-1/FunctionConsumer1/FunctionConsumer1.csproj | Targets net10.0 and updates Functions Worker and Application Insights Worker/ApplicationInsights packages for the Sample 1 queue-triggered consumer. |
| claim-check/code-samples/sample-1/FunctionConsumer1/FunctionConsumer1.cs | Fixes the structured logging template for payload output by correcting the Url {Uri} placeholder formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
claim-check/code-samples/sample-2/ClientConsumer2/SampleSettingsValidator.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@v-federicoar Looks good! Can you review the feedback from Copilot? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…gsValidator.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
skabou
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net 10
Typos
Api Versions
Libraries
Small Changes
Sample 1 working
Sample 2 working
Sample 3 working
Sample 4 working
Producer
Azure Function